[19.07.2022 12:30 AM CET]: Golangci-lint action was running without stopping
Date
19.07.2022, 12:30 AM CET
Summary
Golangci-lint action was running without stopping.
Authors
Stepan Maksymchuk
Impact
All PRs that had any changes related to Golang.
Root Cause
We were using the latest version of golangci-lint
in golangci/golangci-lint-action
. 10 hours ago a new version of golangci-lint
was released: v1.47.0
. Don’t know what exactly is wrong with this version, but all jobs with this version were running without stopping (the longest one was more than 5 hours).
Trigger
New release of golangci-lint
.
Detection
Manual by observing actions for related PR.
Resolution
The golangci-lint
version in golangci/golangci-lint-action
was updated to previous release: v1.46.2
.
Timeline
The timeline related to the issue in form of the table:
Time | Description |
---|---|
Jul 18, 2022, ~12:00 PM | New version of golangci-lint was released. |
Jul 18, 2022, ~7:00 PM | The golangci/golangci-lint-action was triggered by one of the PRs. |
Jul 18, 2022, ~11:30 PM | We’ve noticed the issue and reported it on slack. |
Jul 19, 2022, ~12:30 AM | Fix was tested and merged into the main. |
Action Items
Discuss with the team that we should explicitly set versions everywhere without using the latest - this is the usual practice.
Retrospective
Lessons Learned
Don’t use the latest versions even from stable projects. Once in a while, they break something too.